wardlican commented on code in PR #3920:
URL: https://github.com/apache/amoro/pull/3920#discussion_r2887863970
##########
amoro-ams/src/main/java/org/apache/amoro/server/ha/HighAvailabilityContainer.java:
##########
@@ -49,5 +53,19 @@ public interface HighAvailabilityContainer {
*
* @throws Exception If registration fails or participation in the primary
election fails.
*/
- void registAndElect() throws Exception;
+ void registerAndElect() throws Exception;
+
+ /**
+ * Used in master-slave mode to obtain information about all currently
registered AMS nodes.
+ *
+ * @return List<AmsServerInfo>
+ */
+ List<AmsServerInfo> getAliveNodes();
+
+ /**
+ * Used to determine whether the current AMS node is the primary node.
+ *
+ * @return
Review Comment:
I will add some information about the return value description.
> nit: lack return param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
