majin1102 opened a new pull request, #4106:
URL: https://github.com/apache/amoro/pull/4106
## What changes were proposed in this pull request?
This PR improves the release procedure based on feedback from
0.8.1-incubating release voting, addressing issue #3770.
### Changes:
1. **Exclude AppleDouble files from source tarball**
- Add `--exclude '._*'` and `--exclude '*/._*'` to rsync command
- These macOS metadata files should not be in Apache releases
2. **Include pre-generated git.properties in source tarball**
- Generate git.properties before excluding .git directory
- Copy the file to tarball since target/ is excluded
- This ensures version info is available when building from source
3. **Build binary releases from source tarball for reproducibility**
- `create_binary_release.sh` now requires source tarball to exist first
- Extracts and builds from the source tarball
- Ensures binary releases match the source release (critical for Apache
releases)
4. **Update release guide**
- Correct build order: source release first, then binary release
- Add verification steps for checking AppleDouble files and git.properties
## How was this patch tested?
- Bash syntax validation: `bash -n` for both scripts
- Logic review to ensure git.properties is properly included in tarball
## Release process change
**Before**: Build order didn't matter (scripts were independent)
**After**: Must build source release first, then binary release (binary
depends on source tarball)
```bash
# Correct order:
RELEASE_VERSION=x.x.x bash ./releasing/create_source_release.sh # First
RELEASE_VERSION=x.x.x bash ./releasing/create_binary_release.sh # Second
```
Closes #3770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
