xxubai opened a new pull request, #4111:
URL: https://github.com/apache/amoro/pull/4111

   ## Why are the changes needed?
   
   The Dashboard login authentication provider could be switched to LDAP, but 
the deploy-facing configuration surfaces were incomplete.
   This made LDAP login setup harder for users deploying with binary config or 
Helm.
   
   Close #xxx.
   
   ## Brief change log
   
   - Add LDAP login settings to `dist` default `config.yaml` comments.
   - Add Helm values for LDAP login (`amoroConf.ams.loginAuthLdap.url` and 
`userPattern`).
   - Render LDAP login config keys in Helm `amoro-configmap.yaml` when provided.
   - Document LDAP Dashboard login options in deployment guide.
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] Run test locally before making a pull request
   
   Notes:
   - Verified by local Maven build/package and startup with LDAP configuration.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (yes / no): no
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / 
not documented): not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to