Nam0101 opened a new pull request, #4158: URL: https://github.com/apache/amoro/pull/4158
Hi there! 👋 While exploring the codebase, I noticed a minor opportunity for improvement in `amoro-web/vite.config.ts`. **Context:** The LESS variable `text-color-secondary` is set to `#c0c0ca`, which has poor contrast on light backgrounds (commonly white in Ant Design layouts). Because this token is used globally, secondary labels, helper text, and metadata can become hard to read for low-vision users and may fail WCAG AA contrast requirements. **Proposed fix:** Increase contrast by replacing the token with a darker value that meets AA on white, e.g.: ` 'text-color-secondary': '#595959', ` (or another color with >= 4.5:1 contrast for normal text). Update in `css.preprocessorOptions.less.modifyVars`. **Files changed:** - `amoro-web/vite.config.ts` (modified) *(Note: Tested the changes locally to ensure everything works as expected. Let me know if you need any adjustments, happy to help!)* —— **NamNV** 📍 Hanoi, Vietnam 📧 [email protected] Closes #4157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
