zhoujinsong commented on code in PR #4209:
URL: https://github.com/apache/amoro/pull/4209#discussion_r3233140142
##########
amoro-ams/src/main/java/org/apache/amoro/server/scheduler/inline/InlineTableExecutors.java:
##########
@@ -42,13 +41,6 @@ public static InlineTableExecutors getInstance() {
}
Review Comment:
The old global configs in `AmoroManagementConf` are still present after this
refactor:
```java
// AmoroManagementConf.java
public static final ConfigOption<Boolean> CLEAN_ORPHAN_FILES_ENABLED = ...
public static final ConfigOption<Integer> CLEAN_ORPHAN_FILES_THREAD_COUNT =
...
public static final ConfigOption<Duration> CLEAN_ORPHAN_FILES_INTERVAL = ...
```
And `AmoroManagementConfValidator` still validates them. Since the
configuration has moved to `process-factories.yaml`, these entries are now dead
code. They should either be removed or marked `@Deprecated` with a note
pointing to the new config location, to avoid confusing users who upgrade and
wonder why their old `ams.yaml` settings are silently ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
