somaz94 opened a new pull request, #4243: URL: https://github.com/apache/amoro/pull/4243
### What changes were proposed in this pull request? This PR adds optional Gateway API `HTTPRoute` support to the `charts/amoro` Helm chart, as an alternative to the existing `Ingress` for clusters that have standardized on the [Gateway API](https://gateway-api.sigs.k8s.io/). The change is purely additive — the existing `Ingress` template and its tests are untouched, and `httpRoute.enabled` defaults to `false`, so existing installations are unaffected. - `values.yaml`: new `httpRoute` block (`enabled`, `parentRefs`, `hostname`, `path`, `pathType`, `annotations`, `extraHosts`, `extraRules`), mirroring the shape and `## @param` documentation of the existing `ingress` block. - `templates/amoro-httproute.yaml`: new template gated on `httpRoute.enabled`, rendering a `gateway.networking.k8s.io/v1` `HTTPRoute` that backends to the existing `<fullname>-rest` Service (port `1630`) — the same Service the `Ingress` targets. It reuses the chart's `common.names.*`, `common.labels.standard`, and `common.tplvalues.*` helpers. - `tests/amoro-httproute_test.yaml`: 12 helm-unittest cases mirroring `amoro-ingress_test.yaml`. ### Why are the changes needed? Gateway API is the successor to Ingress and is the recommended north-south routing API on many clusters (Istio, Envoy Gateway, Cilium, Kong, …). Users running a Gateway-API-based ingress data plane currently have to hand-write an `HTTPRoute` outside the chart to expose the Amoro dashboard. This lets them do it declaratively through the chart, the same way `ingress.enabled` works today. ### Brief change log - Add `httpRoute` parameter block to `charts/amoro/values.yaml` - Add `charts/amoro/templates/amoro-httproute.yaml` - Add `charts/amoro/tests/amoro-httproute_test.yaml` (12 helm-unittest cases) ### How was this patch tested? - `helm unittest charts/amoro` — 8 suites / 87 tests pass (12 new HTTPRoute cases + existing suites, no regression). - `helm lint charts/amoro --set httpRoute.enabled=true` — passes. - `helm template` rendered for three scenarios — disabled (0 documents), enabled with `parentRefs` + annotations, and enabled with `extraHosts` + custom path/pathType + `extraRules` — all render as expected and backend to `<release>-amoro-rest:1630`. Parameters are documented inline via `## @param` comments in `values.yaml`, consistent with how the existing `ingress` parameters are documented (the chart `README.md` does not carry a per-parameter table). fix #4242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
