NikhilUjjwal7 opened a new pull request, #4249:
URL: https://github.com/apache/amoro/pull/4249
## Why are the changes needed?
Close #4211.
Legacy `flink-conf.yaml` can contain Flink metric filter values that start
with `*`, for example:
```yaml
xxx.metrics.filter.includes: *RSS:*:*;Heap:Used,Max:*
Close #xxx.
## Brief change log
Updated FlinkOptimizerContainer to load legacy flink-conf.yaml using Flink
GlobalConfiguration.
Kept existing config.yaml loading behavior unchanged.
Added a unit-level regression test for legacy flink-conf.yaml containing
metric filter values starting with *.
## How was this patch tested?
Added regression test :
TestFlinkOptimizerContainer#testReadLegacyFlinkConfigWithMetricFilterIncludes
Add screenshots for manual tests if appropriate
Not applicable.
Run test locally before making a pull request
Ran locally :
./mvnw -pl amoro-ams -am \
-Dtest=TestFlinkOptimizerContainer#testReadLegacyFlinkConfigWithMetricFilterIncludes
\
-Dsurefire.failIfNoSpecifiedTests=false \
test
## Documentation
Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
