czy006 commented on PR #4270: URL: https://github.com/apache/amoro/pull/4270#issuecomment-4981971988
``getThreadPool`` is called from the scan path through ``IcebergTableFileScanHelper.scan()``. Since production standalone optimizers do not call ``IcebergThreadPools.init()``, this fallback can be executed once per scan. The warning is currently logged unconditionally, which may cause significant log I/O and CPU overhead under load, despite the Javadoc stating that the warning is logged only once per pool. Could we restore per-pool warning deduplication, for example with ``ConcurrentHashMap.newKeySet()``, or otherwise rate-limit this log? Please also add a regression test to verify that repeated fallback calls emit the warning only once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
