johntomcat7408-cmyk commented on issue #4240:
URL: https://github.com/apache/amoro/issues/4240#issuecomment-5001364322
Hi, I'd like to take this issue. I reproduced both problems on current
master (27ae8d55f):
1. RestCatalogService.createNamespace() drops
CreateNamespaceRequest.properties(), and getNamespace() doesn't return
properties either. setNamespaceProperties() just throws
UnsupportedOperationException. The underlying reason is that the
database_metadata table has no column for database properties.
2. createTable ignores stage-create. InternalIcebergCreator.create() always
writes the initial metadata file into the final table location, so Trino's
"location must be empty" check fails after stageCreate().
Since the first part needs a schema change, I'd like to split the work into
two PRs:
- PR 1: add a properties column to database_metadata (init + upgrade scripts
for MySQL/Derby/PostgreSQL) and implement the create/get/set-properties
endpoints.
- PR 2: support stage-create: don't write metadata to the final location for
staged creates, and finish the table creation on the following commit.
Please assign it to me if this sounds OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
