zhoujinsong commented on code in PR #4278: URL: https://github.com/apache/amoro/pull/4278#discussion_r3636239850
########## amoro-ams/src/main/java/org/apache/amoro/server/utils/RollingFileCleaner.java: ########## @@ -27,8 +27,11 @@ import org.slf4j.LoggerFactory; import java.net.URI; +import java.util.Comparator; Review Comment: `amoro-ams/src/main/java/org/apache/amoro/server/utils/RollingFileCleaner.java` has no references anywhere in the codebase. It is a stale duplicate of `amoro-format-iceberg/.../RollingFileCleaner.java` which is the one actually used. Instead of modifying it here, please delete it to avoid maintaining two copies. Maybe move the unit test code to model `amoro-format-iceberg` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
