ddupg opened a new pull request, #4309:
URL: https://github.com/apache/amoro/pull/4309
## Why are the changes needed?
`LanceDirectoryV1Catalog.listTables()` invokes `response.getTables()` in an
`else` branch without using the returned value, then invokes it again when
constructing the result. The first invocation has no effect and makes the
control flow unnecessarily verbose.
Close #4308.
## Brief change log
- Remove the redundant `else` branch and unused `response.getTables()`
invocation from `LanceDirectoryV1Catalog.listTables()`.
- Preserve the existing null-response handling and returned table list.
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
Not applicable because this is a behavior-preserving cleanup and the Lance
module currently has no test sources.
- [ ] Add screenshots for manual tests if appropriate
Not applicable.
- [x] Run test locally before making a pull request
`./mvnw -pl amoro-format-lance -am test`
Result: BUILD SUCCESS; Spotless and Checkstyle passed; 97 amoro-common
tests passed; the Lance module compiled successfully.
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
