johntomcat7408-cmyk commented on PR #4311: URL: https://github.com/apache/amoro/pull/4311#issuecomment-5252927802
Thanks for the suggestion. I agree that partitioning the pools by latency sensitivity is a better long-term abstraction and avoids adding a dedicated pool and configuration for each maintenance operation. My proposed interpretation is to generalize the new pool and configuration to iceberg-maintenance-pool and table-manifest-io.maintenance-thread-count, use snapshot expiration as the first consumer, and route the other maintenance paths that currently expose an executor hook to the shared pool. Amoro currently uses Iceberg 1.7.2, where not every listed maintenance operation exposes such a hook, so those operations would remain unchanged until the Iceberg upgrade. Please let me know whether you prefer this scope, or a narrower change in this PR that only generalizes the pool and uses it for snapshot expiration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
