seoyoniee opened a new issue, #4316:
URL: https://github.com/apache/amoro/issues/4316

   ### Description
   
   `tag.auto-create.trigger.period` currently supports only `daily` and 
`hourly` (`TagConfiguration.Period`). This proposes adding `monthly` as a third 
period.
   
   ### Use case/motivation
   
   Auto-created tags are useful as long-lived, point-in-time checkpoints — for 
archival, audit, and recovering data that no longer exists in the current 
snapshot (for example, tables whose upstream source periodically purges old
   rows, so the live table only ever holds a recent window).
   
   For that class of retention requirement, a calendar month is the natural 
granularity. But `tag.auto-create.trigger.period` accepts only `hourly` and 
`daily`, so there is no way to express this.
   
   ### Describe the solution
   
   Add `MONTHLY("monthly")` to `TagConfiguration.Period`.
   
   One part is not a plain enum-constant addition: `periodDuration()` must 
widen from `Duration` to `TemporalAmount`, because `generateTagName` derives 
the tag name as `tagTime.minus(periodDuration())` and a calendar month is not a 
fixed-length duration.
   
   ### Subtasks
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to