xxubai commented on code in PR #4331:
URL: https://github.com/apache/amoro/pull/4331#discussion_r3801788060
##########
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/OptimizingQueue.java:
##########
@@ -775,7 +775,10 @@ private void resetTask(TaskRuntime<RewriteStageTask>
taskRuntime) {
@Override
public boolean isClosed() {
Review Comment:
I'm wondering why we need `isClosed()` if we already have `getStatus()`. If
it represents something other than the process status, we should either rename
it to make its semantics clearer or remove it and use `getStatus()` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
