czy006 commented on code in PR #4293:
URL: https://github.com/apache/amoro/pull/4293#discussion_r3822984588
##########
amoro-common/src/main/java/org/apache/amoro/maintainer/MaintainerMetrics.java:
##########
@@ -40,6 +40,36 @@ public interface MaintainerMetrics {
*/
void recordOrphanMetadataFilesCleaned(int expected, int cleaned);
+ /** Record a successful orphan-file-cleaning run. */
+ void recordSuccess();
Review Comment:
Adding new abstract methods to this public interface can break external
implementations at source or runtime (`AbstractMethodError`). Consider default
no-op methods or a separate optional interface for cleanup-status metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
