aakashofficial-k01 commented on PR #4374: URL: https://github.com/apache/amoro/pull/4374#issuecomment-5654331344
No, I haven't observed this on a live deployment, this came out of an offline code inspection of `RollingFileCleaner`. Seeing `Sets.newConcurrentHashSet()` in `RollingFileCleaner` alongside `planWith(maintenanceExecutor)` in `IcebergTableMaintainer`, I assumed deletion callbacks were also dispatched across the pool and wrote an isolated multi-threaded test around that assumption. I checked `RemoveSnapshots.java:65` and you're right: since Amoro doesn't call `executeDeleteWith`, it defaults to the direct executor on the commit thread, so the test was simulating a scenario that doesn't occur in AMS. Closing this PR and #4373 to avoid unnecessary churn. Thanks for the review and learnings, @j1wonpark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
