czy006 opened a new issue, #4388: URL: https://github.com/apache/amoro/issues/4388
### Search before asking - [x] I have searched in the issues and found no similar issues. #4381 covered the first batch of `LICENSE-binary` gaps (fixed by #4382); this issue tracks the remaining binary gaps and the source-distribution `LICENSE`. ### What would you like to be improved? During the 0.9.0-incubating RC10 IPMC review (https://lists.apache.org/thread/bj3t76cbmcyvhp830d6jlqohmjgtmrh9), reviewers found the source distribution `LICENSE` incomplete (one binding -1 item plus review comments) and the binary distribution `LICENSE-binary` still missing entries. **A. Source distribution `LICENSE` (repo root)** 1. **ICU4J attribution missing** (the binding -1 item): `amoro-format-mixed/amoro-mixed-flink/amoro-mixed-flink-common/src/main/java/org/apache/amoro/flink/lookup/ByteArrayWrapper.java` states it is copied from `com.ibm.icu.util.ByteArrayWrapper`. ICU4J is licensed under the ICU license (not ALv2), so `LICENSE` must carry the applicable ICU copyright notice and license text for this file. 2. **v3.4 `SparkInternalRowWrapper.java` not listed**: `amoro-format-mixed/amoro-mixed-spark/v3.4/amoro-mixed-spark-3.4/src/main/java/org/apache/amoro/spark/SparkInternalRowWrapper.java` is copied from Iceberg, same as the v3.3/v3.5 counterparts which *are* listed — the v3.4 path is missing. 3. **`ThreadLocalCache.java` not listed** in the "from Apache Flink" section: `amoro-format-mixed/amoro-mixed-flink/amoro-mixed-flink-common/src/main/java/org/apache/amoro/flink/util/ThreadLocalCache.java` is marked "Copied from flink-1.18". 4. **Spark-derived parser sources not listed**: `MixedFormatParserUtils.scala` and `MixedFormatSqlExtensionsParser.scala` ("Partially copied from Apache Spark's Parser") exist in the v3.3, v3.4 and v3.5 mixed-spark modules; none of the six files are listed in `LICENSE`. 5. Cosmetic: `Projection.java` appears twice in the Flink section (duplicate line). **B. Binary distribution `LICENSE-binary`** — partially addressed by #4381/#4382, which added the CDDL sections for `javax.activation:activation`, `javax.annotation:javax.annotation-api`, `javax.servlet:javax.servlet-api` and `org.glassfish:javax.json`. Still remaining: 6. `javax.xml.bind:jaxb-api` (bundled in the RC10 binary distribution as `jaxb-api-2.2.2.jar`, CDDL 1.1) has no entry — re-verify against the final dependency list when building the next RC. 7. `javax.transaction:jta` (bundled as `jta-1.1.jar`, CDDL 1.0) has no entry — same verification note. 8. `org.javassist:javassist` is listed under "The BSD License", but javassist is tri-licensed MPL/LGPL/Apache-2.0; it should be moved to the Apache section or annotated accordingly. Note: the binary assembly (`dist/src/main/assemblies/bin.xml`) installs `LICENSE-binary` as the top-level `LICENSE` of the binary tarball, so the two files are maintained separately — repo-root `LICENSE` governs the source release, `LICENSE-binary` governs the binary distribution. ### How should we improve? Update the root `LICENSE` and `LICENSE-binary` as listed above, and include the changes in the next 0.9.0 RC. ### Are you willing to submit PR? - [x] Yes I am willing to submit a PR! ### Code of Conduct - [x] I agree to follow this project's Code of Conduct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
