hutiefang76 opened a new pull request, #4416:
URL: https://github.com/apache/amoro/pull/4416

   ## Why are the changes needed?
   A reachable endpoint such as [::1]:9092 fails before connection validation 
because splitting on colons loses the IPv6 host and port. The existing 
connection helper and KafkaClusterSimpleInfo bean should accept bracketed IPv6 
endpoints while retaining IPv4, optional chroot and fallback behavior.
   
   Fixes #4413.
   
   ## Brief change log
   - Parse endpoints with the existing shaded HostAndPort dependency.
   - Reject empty ports before chroot and bracketed IPv6 empty ports, 
preserving the previous plain host: fallback.
   
   ## How was this patch tested?
   - [x] Add test cases: seven tests exercise real IPv4/IPv6 loopback sockets, 
chroot, bean validation, unreachable-address fallback and malformed/empty 
ports. Four original IPv6 cases fail on the base; the additional empty-port 
regression fails before its guard and passes afterward.
   - [x] Run tests locally: all seven pass in the 15-module Maven reactor; 
Spotless and Checkstyle pass. Tests invoke the helper and bean; no deployed 
Kafka registration flow was tested.
   - [ ] Add screenshots for manual tests if appropriate: connection-helper 
change.
   
   ## Documentation
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? not applicable
   
   ## Post-Deploy Monitoring & Validation
   An AMS maintainer should validate a known reachable bracketed IPv6 endpoint 
and an existing IPv4 endpoint when first exercising this helper after 
deployment. Valid ports should connect; malformed ports should be rejected. 
Restore the previous build if previously working IPv4/chroot endpoints fail. No 
production bean caller or project-specific connection metric was established, 
so this does not claim a deployed Kafka-registration check.
   
   ---
   
   [![Compound 
Engineering](https://img.shields.io/badge/Built_with-Compound_Engineering-6366f1)](https://github.com/EveryInc/compound-engineering-plugin)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to