hutiefang76 opened a new pull request, #4428:
URL: https://github.com/apache/amoro/pull/4428

   ## Why are the changes needed?
   
   IcebergTypeToSparkType maps both Iceberg timestamp variants to Spark 
timestamp. The AMS schema display therefore loses the distinction between 
timestamp without a zone and a zone-adjusted timestamp.
   
   Closes #4426.
   
   ## Brief change log
   
   Map shouldAdjustToUTC=false to Spark TimestampNTZType and keep the 
zone-adjusted variant as TimestampType. Add direct and nested type rendering 
regressions.
   
   ## How was this patch tested?
   
   - [x] Added positive and negative regression tests.
   - [x] Ran the affected tests locally.
   
   JDK 17, default Spark 3.5.8 profile: TestIcebergTypeToSparkType, 3 tests 
passed; 2 failed against the original implementation. Root ./mvnw -q 
-Pskip-dashboard-build validate passed. Spark 3.3/3.4 profile tests were not 
executed.
   
   ```shell
   ./mvnw -q -Pskip-dashboard-build -pl amoro-ams -am 
-Dtest=TestIcebergTypeToSparkType -Dsurefire.failIfNoSpecifiedTests=false test
   ```
   
   ## Documentation
   
   No new feature or configuration. Existing conversion behavior is corrected.
   
   AI assistance: implementation and initial review used DeepSeek; Codex 
coordinated final review and local verification.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to