hutiefang76 commented on issue #4172: URL: https://github.com/apache/amoro/issues/4172#issuecomment-6657808524
On current master `68938a74`, this needs to be checked against #4090: same-thread polling now resets stale `ACKED` tasks, so the older restart-required outcome cannot be assumed. I can investigate the last-task completion failure with a regression using the real AMS persistence fixture. The first step would be to fail the `beginCommitting()` path during `completeTask()`, then inspect both persisted and in-memory task/process/table state. I would compare a completion retry with a same-thread repoll, alongside a successful-completion control. The current `SimpleFuture` callbacks still run inside the completion transaction, so callback and transaction ordering matter here. No regression has been run yet. This scope would focus on the remaining completion/rollback case; #4432 covers the separate disabled-optimizing/cancellation changes. Is anyone currently working on this path, and does this reproduction-first scope fit the remaining issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
