This is an automated email from the ASF dual-hosted git repository.
randall pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-annotator.git
The following commit(s) were added to refs/heads/main by this push:
new e1a1640 Remove eslint-plugin-prettier
e1a1640 is described below
commit e1a1640d8108a00f6dafcc0b6e94a8799f42a2e4
Author: Randall Leeds <[email protected]>
AuthorDate: Sat Jun 22 16:23:39 2024 -0700
Remove eslint-plugin-prettier
Documentation recommends running it as a separate tool.
---
.eslintrc.js | 11 +-
.prettierrc.js | 4 +
package-lock.json | 349 ------------------------------------------------------
package.json | 1 -
4 files changed, 6 insertions(+), 359 deletions(-)
diff --git a/.eslintrc.js b/.eslintrc.js
index 17a205c..219e7dc 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -24,7 +24,7 @@
module.exports = {
root: true,
extends: ['eslint:recommended', 'plugin:import/recommended', 'prettier'],
- plugins: ['import', 'prettier'],
+ plugins: ['import'],
rules: {
'import/extensions': ['error', 'ignorePackages'],
'import/first': 'error',
@@ -50,13 +50,6 @@ module.exports = {
],
'import/unambiguous': 'error',
'no-constant-condition': 'off',
- 'prettier/prettier': [
- 'error',
- {
- singleQuote: true,
- trailingComma: 'all',
- },
- ],
},
settings: {
'import/internal-regex': '^@apache-annotator/',
@@ -73,6 +66,7 @@ module.exports = {
files: [
'.eslintrc.js',
'.mocharc.js',
+ '.prettierrc.js',
'babel-register.js',
'babel.config.js',
'nyc.config.js',
@@ -102,7 +96,6 @@ module.exports = {
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'plugin:import/typescript',
- 'prettier/@typescript-eslint',
],
parserOptions: {
ecmaVersion: 2020,
diff --git a/.prettierrc.js b/.prettierrc.js
new file mode 100644
index 0000000..de2f53c
--- /dev/null
+++ b/.prettierrc.js
@@ -0,0 +1,4 @@
+module.exports = {
+ singleQuote: true,
+ trailingComma: 'all',
+};
diff --git a/package-lock.json b/package-lock.json
index e1577df..1363073 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -35,7 +35,6 @@
"eslint-import-resolver-babel-module": "^5.3.2",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-node": "^11.1.0",
- "eslint-plugin-prettier": "^5.0.0",
"file-loader": "^6.2.0",
"global-jsdom": "^9.1.0",
"husky": "^8.0.3",
@@ -3101,53 +3100,6 @@
"node": ">=14"
}
},
- "node_modules/@pkgr/utils": {
- "version": "2.4.2",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "cross-spawn": "^7.0.3",
- "fast-glob": "^3.3.0",
- "is-glob": "^4.0.3",
- "open": "^9.1.0",
- "picocolors": "^1.0.0",
- "tslib": "^2.6.0"
- },
- "engines": {
- "node": "^12.20.0 || ^14.18.0 || >=16.0.0"
- },
- "funding": {
- "url": "https://opencollective.com/unts"
- }
- },
- "node_modules/@pkgr/utils/node_modules/define-lazy-prop": {
- "version": "3.0.0",
- "dev": true,
- "license": "MIT",
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/@pkgr/utils/node_modules/open": {
- "version": "9.1.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "default-browser": "^4.0.0",
- "define-lazy-prop": "^3.0.0",
- "is-inside-container": "^1.0.0",
- "is-wsl": "^2.2.0"
- },
- "engines": {
- "node": ">=14.16"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
"node_modules/@sigstore/bundle": {
"version": "1.1.0",
"dev": true,
@@ -4559,14 +4511,6 @@
"dev": true,
"license": "Apache-2.0"
},
- "node_modules/big-integer": {
- "version": "1.6.51",
- "dev": true,
- "license": "Unlicense",
- "engines": {
- "node": ">=0.6"
- }
- },
"node_modules/big.js": {
"version": "5.2.2",
"dev": true,
@@ -4656,17 +4600,6 @@
"multicast-dns": "^7.2.5"
}
},
- "node_modules/bplist-parser": {
- "version": "0.2.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "big-integer": "^1.6.44"
- },
- "engines": {
- "node": ">= 5.10.0"
- }
- },
"node_modules/brace-expansion": {
"version": "1.1.11",
"dev": true,
@@ -4773,20 +4706,6 @@
"node": ">=10"
}
},
- "node_modules/bundle-name": {
- "version": "3.0.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "run-applescript": "^5.0.0"
- },
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
"node_modules/byte-size": {
"version": "8.1.1",
"dev": true,
@@ -6028,151 +5947,6 @@
"dev": true,
"license": "MIT"
},
- "node_modules/default-browser": {
- "version": "4.0.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "bundle-name": "^3.0.0",
- "default-browser-id": "^3.0.0",
- "execa": "^7.1.1",
- "titleize": "^3.0.0"
- },
- "engines": {
- "node": ">=14.16"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/default-browser-id": {
- "version": "3.0.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "bplist-parser": "^0.2.0",
- "untildify": "^4.0.0"
- },
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/default-browser/node_modules/execa": {
- "version": "7.2.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "cross-spawn": "^7.0.3",
- "get-stream": "^6.0.1",
- "human-signals": "^4.3.0",
- "is-stream": "^3.0.0",
- "merge-stream": "^2.0.0",
- "npm-run-path": "^5.1.0",
- "onetime": "^6.0.0",
- "signal-exit": "^3.0.7",
- "strip-final-newline": "^3.0.0"
- },
- "engines": {
- "node": "^14.18.0 || ^16.14.0 || >=18.0.0"
- },
- "funding": {
- "url": "https://github.com/sindresorhus/execa?sponsor=1"
- }
- },
- "node_modules/default-browser/node_modules/get-stream": {
- "version": "6.0.1",
- "dev": true,
- "license": "MIT",
- "engines": {
- "node": ">=10"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/default-browser/node_modules/human-signals": {
- "version": "4.3.1",
- "dev": true,
- "license": "Apache-2.0",
- "engines": {
- "node": ">=14.18.0"
- }
- },
- "node_modules/default-browser/node_modules/is-stream": {
- "version": "3.0.0",
- "dev": true,
- "license": "MIT",
- "engines": {
- "node": "^12.20.0 || ^14.13.1 || >=16.0.0"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/default-browser/node_modules/mimic-fn": {
- "version": "4.0.0",
- "dev": true,
- "license": "MIT",
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/default-browser/node_modules/npm-run-path": {
- "version": "5.1.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "path-key": "^4.0.0"
- },
- "engines": {
- "node": "^12.20.0 || ^14.13.1 || >=16.0.0"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/default-browser/node_modules/onetime": {
- "version": "6.0.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "mimic-fn": "^4.0.0"
- },
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/default-browser/node_modules/path-key": {
- "version": "4.0.0",
- "dev": true,
- "license": "MIT",
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/default-browser/node_modules/strip-final-newline": {
- "version": "3.0.0",
- "dev": true,
- "license": "MIT",
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
"node_modules/default-gateway": {
"version": "6.0.3",
"dev": true,
@@ -6892,34 +6666,6 @@
"node": ">=4"
}
},
- "node_modules/eslint-plugin-prettier": {
- "version": "5.0.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "prettier-linter-helpers": "^1.0.0",
- "synckit": "^0.8.5"
- },
- "engines": {
- "node": "^14.18.0 || >=16.0.0"
- },
- "funding": {
- "url": "https://opencollective.com/prettier"
- },
- "peerDependencies": {
- "@types/eslint": ">=8.0.0",
- "eslint": ">=8.0.0",
- "prettier": ">=3.0.0"
- },
- "peerDependenciesMeta": {
- "@types/eslint": {
- "optional": true
- },
- "eslint-config-prettier": {
- "optional": true
- }
- }
- },
"node_modules/eslint-scope": {
"version": "5.1.1",
"dev": true,
@@ -7412,11 +7158,6 @@
"dev": true,
"license": "MIT"
},
- "node_modules/fast-diff": {
- "version": "1.2.0",
- "dev": true,
- "license": "Apache-2.0"
- },
"node_modules/fast-glob": {
"version": "3.3.1",
"dev": true,
@@ -9123,37 +8864,6 @@
"node": ">=0.10.0"
}
},
- "node_modules/is-inside-container": {
- "version": "1.0.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "is-docker": "^3.0.0"
- },
- "bin": {
- "is-inside-container": "cli.js"
- },
- "engines": {
- "node": ">=14.16"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
- "node_modules/is-inside-container/node_modules/is-docker": {
- "version": "3.0.0",
- "dev": true,
- "license": "MIT",
- "bin": {
- "is-docker": "cli.js"
- },
- "engines": {
- "node": "^12.20.0 || ^14.13.1 || >=16.0.0"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
"node_modules/is-interactive": {
"version": "1.0.0",
"dev": true,
@@ -13297,17 +13007,6 @@
"url": "https://github.com/prettier/prettier?sponsor=1"
}
},
- "node_modules/prettier-linter-helpers": {
- "version": "1.0.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "fast-diff": "^1.1.2"
- },
- "engines": {
- "node": ">=6.0.0"
- }
- },
"node_modules/pretty-format": {
"version": "29.7.0",
"dev": true,
@@ -14102,20 +13801,6 @@
"dev": true,
"license": "MIT"
},
- "node_modules/run-applescript": {
- "version": "5.0.0",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "execa": "^5.0.0"
- },
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
"node_modules/run-async": {
"version": "2.4.1",
"dev": true,
@@ -14965,21 +14650,6 @@
"dev": true,
"license": "MIT"
},
- "node_modules/synckit": {
- "version": "0.8.5",
- "dev": true,
- "license": "MIT",
- "dependencies": {
- "@pkgr/utils": "^2.3.1",
- "tslib": "^2.5.0"
- },
- "engines": {
- "node": "^14.18.0 || >=16.0.0"
- },
- "funding": {
- "url": "https://opencollective.com/unts"
- }
- },
"node_modules/tapable": {
"version": "2.2.1",
"dev": true,
@@ -15224,17 +14894,6 @@
"dev": true,
"license": "MIT"
},
- "node_modules/titleize": {
- "version": "3.0.0",
- "dev": true,
- "license": "MIT",
- "engines": {
- "node": ">=12"
- },
- "funding": {
- "url": "https://github.com/sponsors/sindresorhus"
- }
- },
"node_modules/tmp": {
"version": "0.0.33",
"dev": true,
@@ -15640,14 +15299,6 @@
"node": ">= 0.8"
}
},
- "node_modules/untildify": {
- "version": "4.0.0",
- "dev": true,
- "license": "MIT",
- "engines": {
- "node": ">=8"
- }
- },
"node_modules/upath": {
"version": "2.0.1",
"dev": true,
diff --git a/package.json b/package.json
index 747eec1..af97a97 100644
--- a/package.json
+++ b/package.json
@@ -57,7 +57,6 @@
"eslint-import-resolver-babel-module": "^5.3.2",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-node": "^11.1.0",
- "eslint-plugin-prettier": "^5.0.0",
"file-loader": "^6.2.0",
"global-jsdom": "^9.1.0",
"husky": "^8.0.3",