LinkinStars commented on code in PR #884:
URL: https://github.com/apache/incubator-answer/pull/884#discussion_r1542238537
##########
internal/service/unique/uniqid_service.go:
##########
@@ -21,9 +21,27 @@ package unique
import (
"context"
+ "strconv"
)
// UniqueIDRepo unique id repository
type UniqueIDRepo interface {
GenUniqueIDStr(ctx context.Context, key string) (uniqueID string, err
error)
}
+
+type UniqueIDService struct {
+
+}
+
+func NewUniqueIDService() *UniqueIDService {
+ return &UniqueIDService{}
+}
Review Comment:
The reason the above needs to be changed is because this function return the
`point` not a `struct`.
##########
internal/repo/tag/tag_rel_repo.go:
##########
@@ -35,21 +35,25 @@ import (
type tagRelRepo struct {
data *data.Data
uniqueIDRepo unique.UniqueIDRepo
+ uniqueIDService unique.UniqueIDService
}
// NewTagRelRepo new repository
func NewTagRelRepo(data *data.Data,
- uniqueIDRepo unique.UniqueIDRepo) tagcommon.TagRelRepo {
+ uniqueIDRepo unique.UniqueIDRepo,
+ uniqueIDService unique.UniqueIDService,) tagcommon.TagRelRepo {
Review Comment:
You need use `*uniqueIDService unique.UniqueIDService`.
##########
internal/repo/tag/tag_rel_repo.go:
##########
@@ -35,21 +35,25 @@ import (
type tagRelRepo struct {
data *data.Data
uniqueIDRepo unique.UniqueIDRepo
+ uniqueIDService unique.UniqueIDService
Review Comment:
You need use `*uniqueIDService unique.UniqueIDService`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
