Re: [PR] Added isInvalid styles for forms [incubator-answer]

Tue, 07 May 2024 20:53:16 -0700 


shuashuai commented on code in PR #935:
URL: https://github.com/apache/incubator-answer/pull/935#discussion_r1593352138


##########
ui/src/pages/Questions/Ask/index.tsx:
##########
@@ -452,18 +448,18 @@ const Ask = () => {
                 {formData.content.errorMsg}
               </Form.Control.Feedback>
             </Form.Group>
+
             <Form.Group controlId="tags" className="my-3">
               <Form.Label>{t('form.fields.tags.label')}</Form.Label>
-              <Form.Control
-                defaultValue={JSON.stringify(formData.tags.value)}
-                isInvalid={formData.tags.isInvalid}
-                hidden
-              />

Review Comment:
   The cause of the problem is exactly as you described, so I say both 
solutions are possible.
   
   In the second option, I just simplify the use of this component and build 
`<Form.Control.Feedback /> ` into the `TagSelector` component.
   
   eg:
   
![image](https://github.com/apache/incubator-answer/assets/30591202/863a3aa1-c4c8-4bad-a20e-333c500aecae)
   
   usage:
   
![image](https://github.com/apache/incubator-answer/assets/30591202/1ad259c0-8be6-4e52-8c65-b938208542f5)
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to