byerer commented on PR #970:
URL: https://github.com/apache/incubator-answer/pull/970#issuecomment-2144598330
Initially, I also thought it was a front-end issue, because the
encodeURIComponent function was used, so I deleted `encodeURICompontent` in the
functions related to the tag `slugName`.
For example, in `ui/src/router/pathFactory.ts`
```
const tagLanding = (slugName: string) => {
const r = slugName ? `/tags/${encodeURIComponent(slugName)}` : '/tags';
return r;
};
```
Also in `ui/src/components/Tag/index.tsx`
```
const Index: FC<IProps> = ({
...
href ||= pathFactory.tagLanding(encodeURIComponent(data.slug_name));
...
})
```
This will lead to new issues; if the slugName contains '/' or some special
characters, it will result in URI errors.
Thus, I decided to resolve this issue using a method similar to the one used
for handling `UrlTitle`.
I'm not sure if my understanding is correct, and I would be happy to discuss
this issue with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
