shuashuai commented on code in PR #1016:
URL: https://github.com/apache/incubator-answer/pull/1016#discussion_r1677370494


##########
ui/src/pages/Install/index.tsx:
##########
@@ -131,11 +131,35 @@ const Index: FC = () => {
     },
   });
 
+  const updateFormData = (params: FormDataType) => {
+    if (step === 2) {

Review Comment:
   Only when the value of db_type changes, do you need to reset the default 
value
   
    if (Object.keys(params)?.[0] === 'db_type') {
     ...
   }



##########
ui/src/pages/Install/index.tsx:
##########
@@ -131,11 +131,35 @@ const Index: FC = () => {
     },
   });
 
+  const updateFormData = (params: FormDataType) => {
+    if (step === 2) {
+      let updatedFormData = formData;
+      if (params.db_type.value === 'mysql') {

Review Comment:
   params.db_type?.value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to