LinkinStars commented on code in PR #1244:
URL: https://github.com/apache/answer/pull/1244#discussion_r1945572213
##########
internal/install/install_req.go:
##########
@@ -21,12 +21,14 @@ package install
import (
"fmt"
+ "log"
"net/url"
+ "os"
"strings"
- "github.com/apache/answer/internal/base/reason"
- "github.com/apache/answer/internal/base/validator"
- "github.com/apache/answer/pkg/checker"
+ "github.com/apache/incubator-answer/internal/base/reason"
+ "github.com/apache/incubator-answer/internal/base/validator"
+ "github.com/apache/incubator-answer/pkg/checker"
Review Comment:
remove `incubator`
##########
internal/install/install_req.go:
##########
@@ -40,12 +42,17 @@ type CheckConfigFileResp struct {
// CheckDatabaseReq check database
type CheckDatabaseReq struct {
- DbType string `validate:"required,oneof=postgres sqlite3 mysql"
json:"db_type"`
- DbUsername string `json:"db_username"`
- DbPassword string `json:"db_password"`
- DbHost string `json:"db_host"`
- DbName string `json:"db_name"`
- DbFile string `json:"db_file"`
+ DbType string `validate:"required,oneof=postgres sqlite3 mysql"
json:"db_type"`
+ DbUsername string `json:"db_username"`
+ DbPassword string `json:"db_password"`
+ DbHost string `json:"db_host"`
+ DbName string `json:"db_name"`
+ DbFile string `json:"db_file"`
+ Ssl bool `json:"ssl_enabled"`
+ SslMode string `json:"ssl_mode"`
+ SslCrt string `json:"server-ca.pem"`
+ SslKey string `json:"client-cert.pem"`
+ SslCrtClient string `json:"client-key.pem"`
Review Comment:
Please check these json keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]