unical1988 commented on code in PR #1244:
URL: https://github.com/apache/answer/pull/1244#discussion_r1981470283


##########
ui/src/pages/Install/components/SecondStep/index.tsx:
##########
@@ -90,6 +111,49 @@ const Index: FC<Props> = ({ visible, data, changeCallback, 
nextCallback }) => {
           errorMsg: t('db_name.msg'),
         };
       }
+      if (db_type.value === 'postgres') {
+        if (!ssl_enabled.value) {
+          data.ssl_enabled = {
+            value: false,
+            isInvalid: false,
+            errorMsg: t('ssl_enabled.msg'),
+          };
+        } else if (!ssl_mode.value) {
+          data.ssl_mode = {
+            value: 'require',
+            isInvalid: false,
+            errorMsg: '',
+          };

Review Comment:
   is `ssl_enabled  `initialized somewhere? I can edit the code to account only 
for the values of `%_file` but how and where default values for `ssl_mode ` and 
`ssl_enabled ` are set? the current logic initilizes them, but you say it is 
not needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@answer.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to