linclin2024 commented on code in PR #1331:
URL: https://github.com/apache/answer/pull/1331#discussion_r2081970404
##########
cmd/command.go:
##########
@@ -68,7 +68,7 @@ func init() {
buildCmd.Flags().StringVarP(&buildDir, "build-dir", "b", "", "dir for
build process")
- upgradeCmd.Flags().StringVarP(&upgradeVersion, "from", "f", "",
"upgrade from specific version, eg: -f v1.1.0")
+ upgradeCmd.Flags().StringVarP(&upgradeVersion, "from", "f", "",
"upgrade to the specific version from your input, eg: -f v1.1.0")
Review Comment:
Oh...Okay, actually I specially checked how the `upgradeVersion` var was
used. It turns out that I misunderstood this comment line and the function
signature... 😂 I'll recover its description.
-
https://github.com/apache/answer/blob/3f1ed50f6776452c11b6ffdbdc767cd1887d629b/cmd/command.go#L48
-
https://github.com/Octobug/answer/blob/636d4106b6f8d2929b37c479a8286ddcd1842025/internal/migrations/migrations.go#L137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]