LinkinStars commented on PR #294:
URL: https://github.com/apache/answer-plugins/pull/294#issuecomment-5674085050

   Hi @DanielAuerX, yes — we are still interested in supporting an LDAP 
connector. Thank you for picking this up again.
   
   The POST callback change in apache/answer#1612 is the right direction: 
credentials must not be sent in a GET URL. The custom login page is also 
acceptable for now; please do not spend more time polishing its visual design 
yet.
   
   Before we can merge, the two PRs need to complete the existing connector 
state flow:
   
   - The LDAP form must preserve and submit the `state` generated by 
`/connector/login/ldap`.
   - This is required for the one-time callback validation and, in particular, 
for the “bind LDAP account” flow from user settings.
   - Please update the core change so the callback rejects a missing or invalid 
state, rather than treating it as a normal login.
   - Please add CSRF protection appropriate for a same-site credential form.
   
   Could you also rebase onto the current `main` branches and update the plugin 
module path and Answer dependency to match the repository conventions?
   
   For the LDAP connector itself, please add tests for LDAP, LDAPS, StartTLS, 
private CA, failed authentication, and account binding. We also need a stable, 
configurable LDAP attribute for `ExternalID` (for example `entryUUID` / 
`objectGUID`), rather than using a mutable login name.
   
   Once those pieces are updated, we will be happy to review the implementation 
in detail. Thanks again for the contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to