This is an automated email from the ASF dual-hosted git repository.
LinkinStars pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/answer.git
The following commit(s) were added to refs/heads/dev by this push:
new bd7614b8 fix: allow POST for connector redirect route
bd7614b8 is described below
commit bd7614b8f925817363ba95b0184983e93068082a
Author: Daniel Auer <[email protected]>
AuthorDate: Wed Oct 21 10:32:37 2026 +0200
fix: allow POST for connector redirect route
Allow connector redirects to use POST and validate required connector state.
---
internal/controller/connector_controller.go | 5 +++++
internal/router/plugin_api_router.go | 1 +
plugin/connector.go | 4 ++++
3 files changed, 10 insertions(+)
diff --git a/internal/controller/connector_controller.go
b/internal/controller/connector_controller.go
index 28aa5fc6..c81e644f 100644
--- a/internal/controller/connector_controller.go
+++ b/internal/controller/connector_controller.go
@@ -175,6 +175,11 @@ func (cc *ConnectorController) ConnectorRedirect(connector
plugin.Connector) (fn
ctx.Redirect(http.StatusFound, "/50x")
return
}
+ if requirer, ok := connector.(plugin.ConnectorStateRequired);
ok && requirer.ConnectorRequireState() && stateInfo == nil {
+ log.Errorf("missing or invalid connector oauth state
for provider %s", connector.ConnectorSlugName())
+ ctx.Redirect(http.StatusFound, "/50x")
+ return
+ }
if stateInfo != nil && stateInfo.Intent ==
schema.ExternalLoginOAuthStateBindIntent {
if err =
cc.userExternalService.BindExternalLoginToUser(ctx, stateInfo.UserID, u); err
!= nil {
log.Errorf("bind external login failed: %v",
err)
diff --git a/internal/router/plugin_api_router.go
b/internal/router/plugin_api_router.go
index 3b74b3dd..0a72876d 100644
--- a/internal/router/plugin_api_router.go
+++ b/internal/router/plugin_api_router.go
@@ -56,6 +56,7 @@ func (pr *PluginAPIRouter) RegisterUnAuthConnectorRouter(r
*gin.RouterGroup) {
connectorController := pr.connectorController
r.GET(controller.ConnectorLoginRouterPrefix+":name",
connectorController.ConnectorLoginDispatcher)
r.GET(controller.ConnectorRedirectRouterPrefix+":name",
connectorController.ConnectorRedirectDispatcher)
+ r.POST(controller.ConnectorRedirectRouterPrefix+":name",
connectorController.ConnectorRedirectDispatcher)
r.GET("/connector/info", connectorController.ConnectorsInfo)
r.POST("/connector/binding/email",
connectorController.ExternalLoginBindingUserSendEmail)
diff --git a/plugin/connector.go b/plugin/connector.go
index 267cd391..cd8468fc 100644
--- a/plugin/connector.go
+++ b/plugin/connector.go
@@ -44,6 +44,10 @@ type Connector interface {
ConnectorReceiver(ctx *GinContext, receiverURL string) (userInfo
ExternalLoginUserInfo, err error)
}
+type ConnectorStateRequired interface {
+ ConnectorRequireState() bool
+}
+
// ExternalLoginUserInfo external login user info
type ExternalLoginUserInfo struct {
// required. The unique user ID provided by the third-party login