Repository: apex-core Updated Branches: refs/heads/master 5f79cb75d -> 34da9dce2
APEXCORE-740 Load the plugins from setup of setup plugin manager instead of constructor. Project: http://git-wip-us.apache.org/repos/asf/apex-core/repo Commit: http://git-wip-us.apache.org/repos/asf/apex-core/commit/34da9dce Tree: http://git-wip-us.apache.org/repos/asf/apex-core/tree/34da9dce Diff: http://git-wip-us.apache.org/repos/asf/apex-core/diff/34da9dce Branch: refs/heads/master Commit: 34da9dce210de6b97a67b5cf8546432278ac54eb Parents: 5f79cb7 Author: Chinmay Kolhatkar <[email protected]> Authored: Fri Jun 9 15:52:37 2017 +0530 Committer: Chinmay Kolhatkar <[email protected]> Committed: Thu Jun 15 11:13:29 2017 +0530 ---------------------------------------------------------------------- .../stram/plan/logical/DAGSetupPluginManager.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/apex-core/blob/34da9dce/engine/src/main/java/com/datatorrent/stram/plan/logical/DAGSetupPluginManager.java ---------------------------------------------------------------------- diff --git a/engine/src/main/java/com/datatorrent/stram/plan/logical/DAGSetupPluginManager.java b/engine/src/main/java/com/datatorrent/stram/plan/logical/DAGSetupPluginManager.java index 03958f4..ec53128 100644 --- a/engine/src/main/java/com/datatorrent/stram/plan/logical/DAGSetupPluginManager.java +++ b/engine/src/main/java/com/datatorrent/stram/plan/logical/DAGSetupPluginManager.java @@ -52,9 +52,13 @@ public class DAGSetupPluginManager private final Table<DAGSetupEvent.Type, DAGSetupPlugin, EventHandler<DAGSetupEvent>> table = HashBasedTable.create(); - private void loadVisitors(Configuration conf) + private DAGSetupPluginManager(Configuration conf) { this.conf = conf; + } + + private void loadVisitors() + { if (!plugins.isEmpty()) { return; } @@ -119,6 +123,7 @@ public class DAGSetupPluginManager public void setup(DAG dag) { + loadVisitors(); for (DAGSetupPlugin plugin : plugins) { DAGSetupPlugin.Context context = new DefaultDAGSetupPluginContext(dag, conf, plugin); plugin.setup(context); @@ -145,8 +150,7 @@ public class DAGSetupPluginManager public static synchronized DAGSetupPluginManager getInstance(Configuration conf) { - DAGSetupPluginManager manager = new DAGSetupPluginManager(); - manager.loadVisitors(conf); + DAGSetupPluginManager manager = new DAGSetupPluginManager(conf); return manager; } }
