[apex-malhar] branch master updated: APEXMALHAR-2548 Fixed XmlParserApplicationTest test failure

[thw]

This is an automated email from the ASF dual-hosted git repository.

thw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apex-malhar.git


The following commit(s) were added to refs/heads/master by this push:
     new c562a36  APEXMALHAR-2548 Fixed XmlParserApplicationTest test failure
c562a36 is described below

commit c562a36171c4c6470cbd658ee1366fa41ebcb50c
Author: Pramod Immaneni <pra...@apache.org>
AuthorDate: Thu Dec 7 08:56:06 2017 -0800

    APEXMALHAR-2548 Fixed XmlParserApplicationTest test failure
---
 .../main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java    | 6 +++---
 .../java/com/datatorrent/lib/parser/XmlParserApplicationTest.java   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/library/src/main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java 
b/library/src/main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java
index 51eaeee..439a53b 100644
--- a/library/src/main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java
+++ b/library/src/main/java/org/apache/apex/malhar/lib/utils/PubSubHelper.java
@@ -24,6 +24,8 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.apache.hadoop.classification.InterfaceStability;
 
+import com.google.common.base.Preconditions;
+
 import com.datatorrent.api.Context;
 
 @InterfaceStability.Evolving
@@ -57,9 +59,7 @@ public class PubSubHelper
 
   public static URI getURI(String address, boolean useSSL)
   {
-    if (address == null) {
-      throw new NullPointerException("No address specified");
-    }
+    Preconditions.checkNotNull(address,"No address specified");
     String uri = (useSSL ? "wss://" : "ws://") + address + "/pubsub";
     logger.debug("PubSub uri {}", uri);
     return URI.create(uri);
diff --git 
a/library/src/test/java/com/datatorrent/lib/parser/XmlParserApplicationTest.java
 
b/library/src/test/java/com/datatorrent/lib/parser/XmlParserApplicationTest.java
index bd8b4a7..e35d6b0 100644
--- 
a/library/src/test/java/com/datatorrent/lib/parser/XmlParserApplicationTest.java
+++ 
b/library/src/test/java/com/datatorrent/lib/parser/XmlParserApplicationTest.java
@@ -41,7 +41,7 @@ import com.datatorrent.stram.StramLocalCluster;
  */
 public class XmlParserApplicationTest
 {
-  public static int TupleCount;
+  public static volatile int TupleCount;
   public static com.datatorrent.lib.parser.XmlParserTest.EmployeeBean obj;
   @Test
   public void testApplication()

-- 
To stop receiving notification emails like this one, please contact
['"commits@apex.apache.org" <commits@apex.apache.org>'].