Repository: incubator-apex-core Updated Branches: refs/heads/release-3.2 f06544896 -> 031b5785b
APEXCORE-385 make sure to clean up temp app package directories Project: http://git-wip-us.apache.org/repos/asf/incubator-apex-core/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-apex-core/commit/031b5785 Tree: http://git-wip-us.apache.org/repos/asf/incubator-apex-core/tree/031b5785 Diff: http://git-wip-us.apache.org/repos/asf/incubator-apex-core/diff/031b5785 Branch: refs/heads/release-3.2 Commit: 031b5785bfdeac8a587402bbb0f7e73f30183efc Parents: f065448 Author: David Yan <[email protected]> Authored: Mon Mar 14 18:37:12 2016 -0700 Committer: Thomas Weise <[email protected]> Committed: Mon Mar 14 19:16:25 2016 -0700 ---------------------------------------------------------------------- .../java/com/datatorrent/stram/cli/DTCli.java | 28 +++----------------- .../datatorrent/stram/client/AppPackage.java | 2 +- 2 files changed, 5 insertions(+), 25 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-apex-core/blob/031b5785/engine/src/main/java/com/datatorrent/stram/cli/DTCli.java ---------------------------------------------------------------------- diff --git a/engine/src/main/java/com/datatorrent/stram/cli/DTCli.java b/engine/src/main/java/com/datatorrent/stram/cli/DTCli.java index 8a70a56..b870d0f 100644 --- a/engine/src/main/java/com/datatorrent/stram/cli/DTCli.java +++ b/engine/src/main/java/com/datatorrent/stram/cli/DTCli.java @@ -2878,10 +2878,7 @@ public class DTCli public void execute(String[] args, ConsoleReader reader) throws Exception { String jarfile = expandFileName(args[1], true); - AppPackage ap = null; - try { - ap = newAppPackageInstance(new File(jarfile)); - + try (AppPackage ap = newAppPackageInstance(new File(jarfile))) { List<AppInfo> applications = ap.getApplications(); if (args.length >= 3) { @@ -2908,8 +2905,6 @@ public class DTCli } printJson(appList, "applications"); } - } finally { - IOUtils.closeQuietly(ap); } } @@ -3411,17 +3406,12 @@ public class DTCli @Override public void execute(String[] args, ConsoleReader reader) throws Exception { - AppPackage ap = null; - try { - ap = newAppPackageInstance(new File(expandFileName(args[1], true))); + try (AppPackage ap = newAppPackageInstance(new File(expandFileName(args[1], true)))) { JSONSerializationProvider jomp = new JSONSerializationProvider(); JSONObject apInfo = new JSONObject(jomp.getContext(null).writeValueAsString(ap)); apInfo.remove("name"); printJson(apInfo); } - finally { - IOUtils.closeQuietly(ap); - } } } @@ -3727,9 +3717,7 @@ public class DTCli String[] tmpArgs = new String[args.length - 1]; System.arraycopy(args, 1, tmpArgs, 0, args.length - 1); GetOperatorClassesCommandLineInfo commandLineInfo = getGetOperatorClassesCommandLineInfo(tmpArgs); - AppPackage ap = null; - try { - ap = newAppPackageInstance(new File(expandFileName(commandLineInfo.args[0], true))); + try (AppPackage ap = newAppPackageInstance(new File(expandFileName(commandLineInfo.args[0], true)))){ List<String> newArgs = new ArrayList<String>(); List<String> jars = new ArrayList<String>(); for (String jar : ap.getAppJars()) { @@ -3751,9 +3739,6 @@ public class DTCli new GetJarOperatorClassesCommand().execute(newArgs.toArray(new String[]{}), reader); } - finally { - IOUtils.closeQuietly(ap); - } } } @@ -3763,9 +3748,7 @@ public class DTCli @Override public void execute(String[] args, ConsoleReader reader) throws Exception { - AppPackage ap = null; - try { - ap = newAppPackageInstance(new File(expandFileName(args[1], true))); + try (AppPackage ap = newAppPackageInstance(new File(expandFileName(args[1], true)))) { List<String> newArgs = new ArrayList<String>(); List<String> jars = new ArrayList<String>(); for (String jar : ap.getAppJars()) { @@ -3779,9 +3762,6 @@ public class DTCli newArgs.add(args[2]); new GetJarOperatorPropertiesCommand().execute(newArgs.toArray(new String[]{}), reader); } - finally { - IOUtils.closeQuietly(ap); - } } } http://git-wip-us.apache.org/repos/asf/incubator-apex-core/blob/031b5785/engine/src/main/java/com/datatorrent/stram/client/AppPackage.java ---------------------------------------------------------------------- diff --git a/engine/src/main/java/com/datatorrent/stram/client/AppPackage.java b/engine/src/main/java/com/datatorrent/stram/client/AppPackage.java index 20f560e..e321e5e 100644 --- a/engine/src/main/java/com/datatorrent/stram/client/AppPackage.java +++ b/engine/src/main/java/com/datatorrent/stram/client/AppPackage.java @@ -122,6 +122,7 @@ public class AppPackage extends JarFile cleanOnClose = true; contentFolder = Files.createTempDirectory("dt-appPackage-").toFile(); } + directory = contentFolder; Manifest manifest = getManifest(); if (manifest == null) { @@ -138,7 +139,6 @@ public class AppPackage extends JarFile throw new IOException("Not a valid app package. Class-Path is missing from MANIFEST.MF"); } classPath.addAll(Arrays.asList(StringUtils.split(classPathString, " "))); - directory = contentFolder; extractToDirectory(directory, file); if (processAppDirectory) { processAppDirectory(new File(directory, "app"));
