Author: olamy
Date: Mon Sep 24 22:19:58 2012
New Revision: 1389629

URL: http://svn.apache.org/viewvc?rev=1389629&view=rev
Log:
[MRM-1674] While creating admin account, entering invalid password yields no 
error message.

Modified:
    
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/startup.js
    
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/utils.js
    
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/redback/user.js

Modified: 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/startup.js
URL: 
http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/startup.js?rev=1389629&r1=1389628&r2=1389629&view=diff
==============================================================================
--- 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/startup.js
 (original)
+++ 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/startup.js
 Mon Sep 24 22:19:58 2012
@@ -37,11 +37,12 @@ function() {
         displayErrorMessage($.i18n.prop('authz.karma.needed'));
       },
       500: function(data){
+        $.log("error 500:"+data.responseText);
         removeSmallSpinnerImg();
         removeMediumSpinnerImg("#main-content");
         clearUserMessages();
         displayRestError($.parseJSON(data.responseText));
-        $("#main-content" ).html("");
+        //$("#main-content" ).html("");
         //displayErrorMessage($.i18n.prop('error.500'));
       }
     }

Modified: 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/utils.js
URL: 
http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/utils.js?rev=1389629&r1=1389628&r2=1389629&view=diff
==============================================================================
--- 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/utils.js
 (original)
+++ 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/archiva/utils.js
 Mon Sep 24 22:19:58 2012
@@ -312,6 +312,10 @@ require(["jquery","jquery.tmpl","i18n"],
 
     if (data.errorKey && data.errorKey.length>0){
       displayErrorMessage($.i18n.prop( data.errorKey ),idToAppend);
+    } else if (data.errorMessages){
+      $.each(data.errorMessages, function(index, value) {
+        displayErrorMessage( 
$.i18n.prop(data.errorMessages[index].errorKey,data.errorMessages[index].args?data.errorMessages[index].args:null));
+      });
     } else {
       $.log("print data.errorMessage:"+data.errorMessage);
       displayErrorMessage(data.errorMessage,idToAppend);

Modified: 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/redback/user.js
URL: 
http://svn.apache.org/viewvc/archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/redback/user.js?rev=1389629&r1=1389628&r2=1389629&view=diff
==============================================================================
--- 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/redback/user.js
 (original)
+++ 
archiva/trunk/archiva-modules/archiva-web/archiva-webapp-js/src/main/webapp/js/redback/user.js
 Mon Sep 24 22:19:58 2012
@@ -117,7 +117,7 @@ define("redback.user",["jquery","utils",
         });
     };
 
-    this.createAdmin = function() {
+    this.createAdmin = function(succesCallbackFn,errorCallbackFn) {
       $.log("user.js#createAdmin");
       var valid = $("#user-create").valid();
       $.log("create admin");
@@ -142,10 +142,18 @@ define("redback.user",["jquery","utils",
                 checkSecurityLinks();
               }
               loginCall(currentAdminUser.username(), 
currentAdminUser.password(),onSuccessCall);
+              if(succesCallbackFn){
+                succesCallbackFn();
+              }
               return this;
             } else {
               displayErrorMessage("admin user not created");
             }
+          },
+          error: function(data){
+            if(errorCallbackFn){
+              errorCallbackFn();
+            }
           }
         });
     };
@@ -261,10 +269,11 @@ define("redback.user",["jquery","utils",
       if(! $("#user-create" ).valid() ) {
         return;
       }
-      self.user.createAdmin();
-
-      // go to search when admin created
-      window.sammyArchivaApplication.setLocation("#search");
+      self.user.createAdmin(function(){
+          // go to search when admin created
+          window.sammyArchivaApplication.setLocation("#search");
+        }
+      );
     }
   }
 


Reply via email to