GitHub user tliron opened a pull request:
https://github.com/apache/incubator-ariatosca/pull/188
ARIA-324 Refactor ctx access
Our previous use of "." to delimit nested dict keys was wrong (keys
could have a ".") and inflexible. The new implementation uses subsequent
args to move into the dict.
The same format can now be used to access object attributes.
This commit also changes how to support setting values: we must now use
"=" as the penultimate argument with the new value following.
Also fixed: callables will now "grab" the number of args they need
instead of all remaining args, making it possible to do further
inspection on the returned value from the callable. To allow for this,
kwargs are now expected as the first arg rather than the last.
Furthmore, this commit fixes a bad null check in the ctx client, and
also allows it to retrieve Unicode data.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-ariatosca
ARIA-324-refactor-ctx-access
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-ariatosca/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit 956e98b20874b99e80b12849b3c10dc869a4b4f6
Author: Tal Liron <[email protected]>
Date: 2017-07-27T22:58:17Z
ARIA-324 Refactor ctx proxy access
Our previous use of "." to delimit nested dict keys was wrong (keys
could have a ".") and inflexible. The new implementation uses subsequent
args to move into the dict. The same format can now be used to access
object attributes.
This commit also changes how to support setting values: we must now use
"=" as the penultimate argument with the new value following.
Also fixed: callables will now "grab" the number of args they need
instead of all remaining args, making it possible to do further
inspection on the returned value from the callable. To allow for this,
kwargs are now expected as the first arg rather than the last.
Relatedly, this commit instruments all parameter fields from all models
and fixes related bugs in the instrumentation implementation.
Furthmore, this commit fixes a bad null check in the ctx client, and
also allows it to retrieve Unicode data.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
