Github user AviaE commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132137742
  
    --- Diff: aria/orchestrator/topology/topology.py ---
    @@ -50,28 +49,33 @@ class Topology(issue.Reporter):
             models.Type: models.Type
         }
     
    -    def __init__(self, model_storage=None, *args, **kwargs):
    -        # TODO: model storage is required only for the list of plugins, 
can we get it
    -        # somewhere else?
    +    def __init__(self, *args, **kwargs):
             super(Topology, self).__init__(*args, **kwargs)
    -        self._model_storage = model_storage
    -        self._handlers = dict(self._init_handlers(instance_handler),
    -                              **self._init_handlers(template_handler))
    +        self._models_to_handlers = 
dict(self._init_handlers(instance_handler),
    +                                        
**self._init_handlers(template_handler))
     
         @staticmethod
         def _init_handlers(module_):
    +        """
    +        Register handlers from a module to the models
    +
    +        :param module_: The module to look for handlers
    +        :return: a dict where key is the models class, and the value is 
the handler class
    +        associated with it from the provided modukle
    --- End diff --
    
    modukle --> module.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to