[GitHub] incubator-ariatosca pull request #207: ARIA-1 Parser test suite

[mxmrlv]

Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/207#discussion_r149669453
  
    --- Diff: extensions/aria_extension_tosca/simple_v1_0/assignments.py ---
    @@ -144,6 +144,17 @@ def _get_type(self, context):
                 # In RelationshipAssignment
                 the_type = the_type[0] # This could be a RelationshipTemplate
     
    +            if isinstance(self._container._container, 
RequirementAssignment):
    --- End diff --
    
    alot of cascading ifs, consider using `if not 
isinstance(self._container._container, RequirementAssignment): return False` 
etc...


---