Github user mxmrlv commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/207#discussion_r150785288
  
    --- Diff: aria/parser/presentation/field_validators.py ---
    @@ -14,12 +14,29 @@
     # limitations under the License.
     
     
    +from ...utils.formatting import safe_repr
     from ..validation import Issue
     from .utils import (parse_types_dict_names, report_issue_for_unknown_type,
                         report_issue_for_parent_is_self, 
report_issue_for_unknown_parent_type,
                         report_issue_for_circular_type_hierarchy)
     
     
    +def not_negative_validator(field, presentation, context):
    +    """
    +    Makes sure that the field is not negative.
    +
    +    Can be used with the :func:`field_validator` decorator.
    +    """
    +
    +    field.default_validate(presentation, context)
    +    value = getattr(presentation, field.name)
    +    if (value is not None) and (value < 0):
    --- End diff --
    
    can't the value be not `None` nor and number?


---

Reply via email to