Repository: arrow Updated Branches: refs/heads/master 8b64a4fb2 -> 19da86ab9
ARROW-817: [Python] Fix comment in date32 conversion Author: Wes McKinney <wes.mckin...@twosigma.com> Closes #536 from wesm/ARROW-817 and squashes the following commits: 3982948 [Wes McKinney] Fix comment Project: http://git-wip-us.apache.org/repos/asf/arrow/repo Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/19da86ab Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/19da86ab Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/19da86ab Branch: refs/heads/master Commit: 19da86ab96fa839786eef768ff4521f46acaa3a4 Parents: 8b64a4f Author: Wes McKinney <wes.mckin...@twosigma.com> Authored: Thu Apr 13 11:16:38 2017 -0400 Committer: Wes McKinney <wes.mckin...@twosigma.com> Committed: Thu Apr 13 11:16:38 2017 -0400 ---------------------------------------------------------------------- cpp/src/arrow/python/pandas_convert.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/arrow/blob/19da86ab/cpp/src/arrow/python/pandas_convert.cc ---------------------------------------------------------------------- diff --git a/cpp/src/arrow/python/pandas_convert.cc b/cpp/src/arrow/python/pandas_convert.cc index 643c5fb..b33aea4 100644 --- a/cpp/src/arrow/python/pandas_convert.cc +++ b/cpp/src/arrow/python/pandas_convert.cc @@ -1504,8 +1504,7 @@ class DatetimeBlock : public PandasBlock { const ChunkedArray& data = *col.get()->data(); if (type == Type::DATE32) { - // Date64Type is millisecond timestamp stored as int64_t - // TODO(wesm): Do we want to make sure to zero out the milliseconds? + // Convert from days since epoch to datetime64[ns] ConvertDatetimeNanos<int32_t, kNanosecondsInDay>(data, out_buffer); } else if (type == Type::DATE64) { // Date64Type is millisecond timestamp stored as int64_t