Repository: arrow
Updated Branches:
  refs/heads/master a4813bdd1 -> 298e34324


ARROW-1673: [Python] Add support for numpy 'bool' type

This is currently a workaround until the Arrow tensor supports zero copy of 
byte-length booleans.

Author: Philipp Moritz <pcmor...@gmail.com>

Closes #1199 from pcmoritz/ndarray-bool and squashes the following commits:

14943a09 [Philipp Moritz] deploy workaround
8fce724c [Philipp Moritz] update
ad4c6b97 [Philipp Moritz] change bool width to 1 byte
11c7ed3b [Philipp Moritz] add support for numpy 'bool' type


Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/298e3432
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/298e3432
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/298e3432

Branch: refs/heads/master
Commit: 298e343240173e0a326495154f196565adc8d301
Parents: a4813bd
Author: Philipp Moritz <pcmor...@gmail.com>
Authored: Wed Oct 18 17:07:41 2017 -0400
Committer: Wes McKinney <wes.mckin...@twosigma.com>
Committed: Wed Oct 18 17:07:41 2017 -0400

----------------------------------------------------------------------
 cpp/src/arrow/python/python_to_arrow.cc    | 1 -
 python/pyarrow/tests/test_serialization.py | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/arrow/blob/298e3432/cpp/src/arrow/python/python_to_arrow.cc
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/python/python_to_arrow.cc 
b/cpp/src/arrow/python/python_to_arrow.cc
index ab444f2..47d48d7 100644
--- a/cpp/src/arrow/python/python_to_arrow.cc
+++ b/cpp/src/arrow/python/python_to_arrow.cc
@@ -528,7 +528,6 @@ Status SerializeArray(PyObject* context, PyArrayObject* 
array, SequenceBuilder*
                       std::vector<PyObject*>* tensors_out) {
   int dtype = PyArray_TYPE(array);
   switch (dtype) {
-    case NPY_BOOL:
     case NPY_UINT8:
     case NPY_INT8:
     case NPY_UINT16:

http://git-wip-us.apache.org/repos/asf/arrow/blob/298e3432/python/pyarrow/tests/test_serialization.py
----------------------------------------------------------------------
diff --git a/python/pyarrow/tests/test_serialization.py 
b/python/pyarrow/tests/test_serialization.py
index 7e8060b..460a11b 100644
--- a/python/pyarrow/tests/test_serialization.py
+++ b/python/pyarrow/tests/test_serialization.py
@@ -257,7 +257,7 @@ def test_default_dict_serialization(large_memory_map):
 
 def test_numpy_serialization(large_memory_map):
     with pa.memory_map(large_memory_map, mode="r+") as mmap:
-        for t in ["int8", "uint8", "int16", "uint16", "int32", "uint32",
+        for t in ["bool", "int8", "uint8", "int16", "uint16", "int32", 
"uint32",
                   "float16", "float32", "float64"]:
             obj = np.random.randint(0, 10, size=(100, 100)).astype(t)
             serialization_roundtrip(obj, mmap)

Reply via email to