[arrow] branch master updated: ARROW-2983: [Packaging] Verify source release and binary artifacts in different scripts

[wesm]

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 1c7bded  ARROW-2983: [Packaging] Verify source release and binary 
artifacts in different scripts
1c7bded is described below

commit 1c7bded2323e5e892fd4a0b721f14ef6793437e2
Author: Krisztián Szűcs <szucs.kriszt...@gmail.com>
AuthorDate: Mon Oct 1 08:25:02 2018 -0400

    ARROW-2983: [Packaging] Verify source release and binary artifacts in 
different scripts
    
    Author: Krisztián Szűcs <szucs.kriszt...@gmail.com>
    
    Closes #2675 from kszucs/ARROW-2983 and squashes the following commits:
    
    9cec0d428 <Krisztián Szűcs> argument to validate source or binary artifacts
---
 dev/release/verify-release-candidate.sh | 56 +++++++++++++++++++--------------
 1 file changed, 32 insertions(+), 24 deletions(-)

diff --git a/dev/release/verify-release-candidate.sh 
b/dev/release/verify-release-candidate.sh
index 7e5b167..6072783 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -29,11 +29,17 @@
 # LD_LIBRARY_PATH
 
 case $# in
-  2) VERSION="$1"
-     RC_NUMBER="$2"
+  3) ARTIFACT="$1"
+     VERSION="$2"
+     RC_NUMBER="$3"
+     case $ARTIFACT in
+       source|binaries) ;;
+       *) echo "Invalid argument: '${ARTIFACT}', valid options are 'source' or 
'binaries'"
+          exit 1
+          ;;
+     esac
      ;;
-
-  *) echo "Usage: $0 X.Y.Z RC_NUMBER"
+  *) echo "Usage: $0 source|binaries X.Y.Z RC_NUMBER"
      exit 1
      ;;
 esac
@@ -309,28 +315,30 @@ if [ "$(uname)" == "Darwin" ]; then
 else
   NPROC=$(nproc)
 fi
-VERSION=$1
-RC_NUMBER=$2
-
-TARBALL=apache-arrow-$1.tar.gz
 
 import_gpg_keys
-verify_binary_artifacts
-
-DIST_NAME="apache-arrow-${VERSION}"
-fetch_archive $DIST_NAME
-tar xvzf ${DIST_NAME}.tar.gz
-cd ${DIST_NAME}
-
-test_package_java
-setup_miniconda
-test_and_install_cpp
-test_python
-test_glib
-test_ruby
-test_js
-test_integration
-test_rust
+
+if [ "$ARTIFACT" == "source" ]; then
+  TARBALL=apache-arrow-$1.tar.gz
+  DIST_NAME="apache-arrow-${VERSION}"
+
+  fetch_archive $DIST_NAME
+  tar xvzf ${DIST_NAME}.tar.gz
+  cd ${DIST_NAME}
+
+  test_package_java
+  setup_miniconda
+  test_and_install_cpp
+  test_python
+  test_glib
+  test_ruby
+  test_js
+  test_integration
+  test_rust
+else
+  # takes longer on slow network
+  verify_binary_artifacts
+fi
 
 echo 'Release candidate looks good!'
 exit 0