This is an automated email from the ASF dual-hosted git repository.
wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 0bfdb80 ARROW-4889: [C++] Add STATUS messages for Protobuf in CMake
0bfdb80 is described below
commit 0bfdb8048743707683be332b975dfbddd6054ea4
Author: Korn, Uwe <[email protected]>
AuthorDate: Fri Mar 15 09:03:12 2019 -0500
ARROW-4889: [C++] Add STATUS messages for Protobuf in CMake
This allows for better information when users report problems with Protobuf
detection.
Author: Korn, Uwe <[email protected]>
Closes #3913 from xhochy/ARROW-4889 and squashes the following commits:
3a84ea391 <Korn, Uwe> ARROW-4889: Add STATUS messages for Protobuf in CMake
---
cpp/cmake_modules/ThirdpartyToolchain.cmake | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 3fce0b7..1c290b2 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -974,6 +974,7 @@ endmacro()
if (ARROW_WITH_PROTOBUF)
resolve_dependency(Protobuf)
+
# TODO: Don't use global includes but rather target_include_directories
include_directories(SYSTEM ${PROTOBUF_INCLUDE_DIR})
@@ -1001,6 +1002,16 @@ if (ARROW_WITH_PROTOBUF)
IMPORTED_LOCATION "${PROTOBUF_PROTOC_EXECUTABLE}"
)
endif()
+
+ # Log protobuf paths as we often see issues with mixed sources for
+ # the libraries and protoc.
+ get_target_property(PROTOBUF_PROTOC_EXECUTABLE protobuf::protoc
IMPORTED_LOCATION)
+ message(STATUS "Found protoc: ${PROTOBUF_PROTOC_EXECUTABLE}")
+ # Protobuf_PROTOC_LIBRARY is set by all versions of FindProtobuf.cmake
+ message(STATUS "Found libprotoc: ${Protobuf_PROTOC_LIBRARY}")
+ get_target_property(PROTOBUF_LIBRARY protobuf::libprotobuf IMPORTED_LOCATION)
+ message(STATUS "Found libprotobuf: ${PROTOBUF_LIBRARY}")
+ message(STATUS "Found protobuf headers: ${PROTOBUF_INCLUDE_DIR}")
endif()
if (MSVC)
