kou commented on a change in pull request #16: ARROW-6260: [Website] Use deploy
key on Travis to build and push to asf-site
URL: https://github.com/apache/arrow-site/pull/16#discussion_r316460102
##########
File path: build-and-deploy.sh
##########
@@ -3,13 +3,25 @@ set -ev
if [ "${TRAVIS_BRANCH}" = "master" ] && [ "${TRAVIS_PULL_REQUEST}" = "false"
]; then
- if [ -z "${GITHUB_PAT}" ]; then
+ if [ -z "${GITHUB_PAT}" ] && [ -z "${DEPLOY_KEY}" ]; then
# Don't build because we can't publish
- echo "To publish the site, you must set a GITHUB_PAT at"
+ echo "To publish the site, you must set a GITHUB_PAT or DEPLOY_KEY at"
echo "https://travis-ci.org/${TRAVIS_REPO_SLUG}/settings";
exit 1
fi
+ if [ "${DEPLOY_KEY}" != "" ]; then
Review comment:
Could you use one of `-z "..."` style or `"..." != ""` style in this script
for consistency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
