nealrichardson commented on a change in pull request #23: ARROW-6127: [Website] 
Add favicons and meta tags
URL: https://github.com/apache/arrow-site/pull/23#discussion_r325968755
 
 

 ##########
 File path: README.md
 ##########
 @@ -68,6 +68,10 @@ Run the following to generate HTML files and run the web 
site locally.
 bundle exec jekyll serve
 ```
 
+## Deployment
+
+On commits to the `master` branch of `apache/arrow-site`, the rendered static 
site will be published to the `asf-site` branch using GitHub Actions. On a 
fork, it will deploy to your `gh-pages` branch for deployment via GitHub Pages; 
this is useful for previewing changes you're proposing. To enable this 
deployment on your fork, you'll need to sign up for GitHub Actions 
[here](https://github.com/features/actions/signup).
 
 Review comment:
   I'll revise the readme. IMO push to master on a fork should build and push 
to gh-pages, not asf-site. But PR instead works, assuming it works. Though it's 
not seeming to work on my fork and I can't figure out why. I don't see any 
other places where I could turn on GitHub Actions 
https://github.com/nealrichardson/arrow-site/pull/3
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to