This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new aa42720 ARROW-7196: [Ruby] Remove needless
BinaryArrayBuilder#append_values
aa42720 is described below
commit aa42720257536327a20f43410bf768710592ff74
Author: Sutou Kouhei <[email protected]>
AuthorDate: Wed Nov 20 10:55:45 2019 +0900
ARROW-7196: [Ruby] Remove needless BinaryArrayBuilder#append_values
It's provided by Apache Arrow GLib's
garrow_binary_array_builder_append_values() now.
Closes #5854 from
kou/ruby-remove-needless-binary-array-builder-append-values and squashes the
following commits:
44b9dd151 <Sutou Kouhei> Remove needless BinaryArrayBuilder#append_values
Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
ruby/red-arrow/lib/arrow/binary-array-builder.rb | 36 ------------------------
ruby/red-arrow/lib/arrow/loader.rb | 1 -
2 files changed, 37 deletions(-)
diff --git a/ruby/red-arrow/lib/arrow/binary-array-builder.rb
b/ruby/red-arrow/lib/arrow/binary-array-builder.rb
deleted file mode 100644
index c780374..0000000
--- a/ruby/red-arrow/lib/arrow/binary-array-builder.rb
+++ /dev/null
@@ -1,36 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-module Arrow
- class BinaryArrayBuilder
- def append_values(values, is_valids=nil)
- if is_valids
- is_valids.each_with_index do |is_valid, i|
- if is_valid
- append_value(values[i])
- else
- append_null
- end
- end
- else
- values.each do |value|
- append_value(value)
- end
- end
- end
- end
-end
diff --git a/ruby/red-arrow/lib/arrow/loader.rb
b/ruby/red-arrow/lib/arrow/loader.rb
index 5ffd0af..60242e2 100644
--- a/ruby/red-arrow/lib/arrow/loader.rb
+++ b/ruby/red-arrow/lib/arrow/loader.rb
@@ -41,7 +41,6 @@ module Arrow
require "arrow/array"
require "arrow/array-builder"
require "arrow/bigdecimal-extension"
- require "arrow/binary-array-builder"
require "arrow/chunked-array"
require "arrow/column"
require "arrow/compression-type"
