This is an automated email from the ASF dual-hosted git repository.
npr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new a88635a ARROW-9485: [R] Better shared library stripping
a88635a is described below
commit a88635a3779ac5067fba20e28391bf380acad872
Author: Neal Richardson <[email protected]>
AuthorDate: Wed Jul 15 11:05:28 2020 -0700
ARROW-9485: [R] Better shared library stripping
This effectively adds stripping for macOS (turns out the correct flag was
`-x` not `-S`) but also should work better in case `strip` is in a different
location.
Closes #7775 from nealrichardson/better-stripping
Authored-by: Neal Richardson <[email protected]>
Signed-off-by: Neal Richardson <[email protected]>
---
r/configure | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/r/configure b/r/configure
index d778cc5..e2c7287 100755
--- a/r/configure
+++ b/r/configure
@@ -199,15 +199,11 @@ fi
sed -e "s|@cflags@|$PKG_CFLAGS|" -e "s|@libs@|$PKG_LIBS|" src/Makevars.in >
src/Makevars
# Add stripping
-if [ -e "/usr/bin/strip" ]; then
- if [ "$UNAME" = "Darwin" ]; then
- STRIP_FLAGS="-S";
- else
- STRIP_FLAGS="--strip-debug";
- fi
+if [ "$R_STRIP_SHARED_LIB" != "" ]; then
+ # R_STRIP_SHARED_LIB is set in the global Renviron and should be available
here
echo "
strip: \$(SHLIB)
- /usr/bin/strip $STRIP_FLAGS \$(SHLIB) >/dev/null 2>&1 || true
+ $R_STRIP_SHARED_LIB \$(SHLIB) >/dev/null 2>&1 || true
.phony: strip
" >> src/Makevars
