This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 7ec917b ARROW-10802: [C++] remove special casing for
Dictionary[NullType] in parquet column writer
7ec917b is described below
commit 7ec917b80461f0114dcb2536b80e16f42cb45430
Author: Andrew Wieteska <andrew.r.wiete...@gmail.com>
AuthorDate: Mon Dec 7 15:54:10 2020 +0900
ARROW-10802: [C++] remove special casing for Dictionary[NullType] in
parquet column writer
ARROW-1648 was fixed a while back (in 0.8) so we can now rely on
`arrow::compute::Cast`
Closes #8828 from arw2019/column_writer-DictNullType-special-casing
Authored-by: Andrew Wieteska <andrew.r.wiete...@gmail.com>
Signed-off-by: Sutou Kouhei <k...@clear-code.com>
---
cpp/src/parquet/column_writer.cc | 7 -------
1 file changed, 7 deletions(-)
diff --git a/cpp/src/parquet/column_writer.cc b/cpp/src/parquet/column_writer.cc
index 4d3197b..e35eeac 100644
--- a/cpp/src/parquet/column_writer.cc
+++ b/cpp/src/parquet/column_writer.cc
@@ -1011,13 +1011,6 @@ Status ConvertDictionaryToDense(const ::arrow::Array&
array, MemoryPool* pool,
const ::arrow::DictionaryType& dict_type =
static_cast<const ::arrow::DictionaryType&>(*array.type());
- // TODO(ARROW-1648): Remove this special handling once we require an Arrow
- // version that has this fixed.
- if (dict_type.value_type()->id() == ::arrow::Type::NA) {
- *out = std::make_shared<::arrow::NullArray>(array.length());
- return Status::OK();
- }
-
::arrow::compute::ExecContext ctx(pool);
ARROW_ASSIGN_OR_RAISE(Datum cast_output,
::arrow::compute::Cast(array.data(),
dict_type.value_type(),
