kou commented on a change in pull request #142:
URL: https://github.com/apache/arrow-site/pull/142#discussion_r694565267
##########
File path: Rakefile
##########
@@ -23,7 +23,11 @@ webpacked_js = "javascript/main.js"
installed_package_lock_json = "node_modules/.package-lock.json"
file installed_package_lock_json => ["package.json", "package-lock.json"] do
- sh("npm", "install", "--no-save")
+ if production?
+ sh("npm", "ci")
+ else
+ sh("npm", "install", "--no-save")
+ end
Review comment:
What is the difference of `npm ci` and `npm install --no-save`?
##########
File path: .github/workflows/deploy.yml
##########
@@ -30,9 +30,11 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
- - uses: actions/setup-node@v2
Review comment:
Oh, I missed this in #141...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
