This is an automated email from the ASF dual-hosted git repository.
emkornfield pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 1049dde ARROW-13544 [Java]: Remove APIs that have been deprecated for
long (Changes to ArrowBuf)
1049dde is described below
commit 1049dde95ed09671eba1453b9984d3a1ac43f82e
Author: liyafan82 <[email protected]>
AuthorDate: Sun Sep 12 14:25:29 2021 -0700
ARROW-13544 [Java]: Remove APIs that have been deprecated for long (Changes
to ArrowBuf)
See https://issues.apache.org/jira/browse/ARROW-13544
According to the discussion in
https://github.com/apache/arrow/pull/10864#issuecomment-895707729, we want to
split the task into multiple parts.
This PR is for the changes related to `ArrowBuf`
Closes #10901 from liyafan82/fly_0810_dep
Authored-by: liyafan82 <[email protected]>
Signed-off-by: Micah Kornfield <[email protected]>
---
.../java/org/apache/arrow/memory/ArrowBuf.java | 43 ----------------------
.../apache/arrow/vector/ipc/JsonFileWriter.java | 2 +-
2 files changed, 1 insertion(+), 44 deletions(-)
diff --git
a/java/memory/memory-core/src/main/java/org/apache/arrow/memory/ArrowBuf.java
b/java/memory/memory-core/src/main/java/org/apache/arrow/memory/ArrowBuf.java
index ea5e29f..d782707 100644
---
a/java/memory/memory-core/src/main/java/org/apache/arrow/memory/ArrowBuf.java
+++
b/java/memory/memory-core/src/main/java/org/apache/arrow/memory/ArrowBuf.java
@@ -1195,51 +1195,8 @@ public final class ArrowBuf implements AutoCloseable {
}
}
- /**
- * Following are wrapper methods to keep this backward compatible.
- */
- @Deprecated
- public void release() {
- referenceManager.release();
- }
-
- @Deprecated
- public void release(int decrement) {
- referenceManager.release(decrement);
- }
-
- @Deprecated
- public void retain() {
- referenceManager.retain();
- }
-
- @Deprecated
- public void retain(int increment) {
- referenceManager.retain(increment);
- }
-
- @Deprecated
public ArrowBuf clear() {
this.readerIndex = this.writerIndex = 0;
return this;
}
-
- /**
- * Initialize the reader and writer index.
- * @param readerIndex index to read from
- * @param writerIndex index to write to
- * @return this
- */
- @Deprecated
- public ArrowBuf setIndex(int readerIndex, int writerIndex) {
- if (readerIndex >= 0 && readerIndex <= writerIndex && writerIndex <=
this.capacity()) {
- this.readerIndex = readerIndex;
- this.writerIndex = writerIndex;
- return this;
- } else {
- throw new IndexOutOfBoundsException(String.format("readerIndex: %d,
writerIndex: %d " +
- "(expected:0 <= readerIndex <= writerIndex <= capacity(%d))",
readerIndex, writerIndex, this.capacity()));
- }
- }
-
}
diff --git
a/java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java
b/java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java
index f6cd3bc..58760c1 100644
--- a/java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java
+++ b/java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java
@@ -232,7 +232,7 @@ public class JsonFileWriter implements AutoCloseable {
ArrowBuf vectorBufferTmp = vector.getAllocator().buffer(4);
vectorBufferTmp.setInt(0, 0);
writeValueToGenerator(bufferType, vectorBufferTmp, null, vector,
i);
- vectorBufferTmp.release();
+ vectorBufferTmp.close();
} else {
writeValueToGenerator(bufferType, vectorBuffer, null, vector, i);
}