[arrow] branch master updated: ARROW-14016: [C++] Wrong type_name used for directory partitioning

[westonpace]

This is an automated email from the ASF dual-hosted git repository.

westonpace pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new e5f3e04  ARROW-14016: [C++] Wrong type_name used for directory 
partitioning
e5f3e04 is described below

commit e5f3e04b4b80c9b9c53f1f0f71f39d9f8308dced
Author: Weston Pace <weston.p...@gmail.com>
AuthorDate: Fri Sep 17 15:32:04 2021 -1000

    ARROW-14016: [C++] Wrong type_name used for directory partitioning
    
    Trivial change to fix the type_name provided by DirectoryPartitioning. It 
appears to have been left from when it was called SchemaPartitioner. See: 
https://github.com/apache/arrow/pull/6153
    
    Closes #11172 from 
westonpace/bugfix/ARROW-14016-fix-directory-partitioning-type-name
    
    Authored-by: Weston Pace <weston.p...@gmail.com>
    Signed-off-by: Weston Pace <weston.p...@gmail.com>
---
 c_glib/test/dataset/test-partitioning.rb | 2 +-
 cpp/src/arrow/dataset/partition.cc       | 2 +-
 cpp/src/arrow/dataset/partition.h        | 2 +-
 python/pyarrow/_dataset.pyx              | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/c_glib/test/dataset/test-partitioning.rb 
b/c_glib/test/dataset/test-partitioning.rb
index d98e51f..2b33b1e 100644
--- a/c_glib/test/dataset/test-partitioning.rb
+++ b/c_glib/test/dataset/test-partitioning.rb
@@ -29,6 +29,6 @@ class TestDatasetPartitioning < Test::Unit::TestCase
   def test_directory
     schema = build_schema(year: Arrow::UInt16DataType.new)
     partitioning = ArrowDataset::DirectoryPartitioning.new(schema)
-    assert_equal("schema", partitioning.type_name)
+    assert_equal("directory", partitioning.type_name)
   end
 end
diff --git a/cpp/src/arrow/dataset/partition.cc 
b/cpp/src/arrow/dataset/partition.cc
index 9054a7b..8db9d7c 100644
--- a/cpp/src/arrow/dataset/partition.cc
+++ b/cpp/src/arrow/dataset/partition.cc
@@ -503,7 +503,7 @@ class DirectoryPartitioningFactory : public 
KeyValuePartitioningFactory {
     util::InitializeUTF8();
   }
 
-  std::string type_name() const override { return "schema"; }
+  std::string type_name() const override { return "directory"; }
 
   Result<std::shared_ptr<Schema>> Inspect(
       const std::vector<std::string>& paths) override {
diff --git a/cpp/src/arrow/dataset/partition.h 
b/cpp/src/arrow/dataset/partition.h
index c074010..aa6958e 100644
--- a/cpp/src/arrow/dataset/partition.h
+++ b/cpp/src/arrow/dataset/partition.h
@@ -210,7 +210,7 @@ class ARROW_DS_EXPORT DirectoryPartitioning : public 
KeyValuePartitioning {
                                  ArrayVector dictionaries = {},
                                  KeyValuePartitioningOptions options = {});
 
-  std::string type_name() const override { return "schema"; }
+  std::string type_name() const override { return "directory"; }
 
   /// \brief Create a factory for a directory partitioning.
   ///
diff --git a/python/pyarrow/_dataset.pyx b/python/pyarrow/_dataset.pyx
index 7342d9c..506939c 100644
--- a/python/pyarrow/_dataset.pyx
+++ b/python/pyarrow/_dataset.pyx
@@ -1952,7 +1952,7 @@ cdef class Partitioning(_Weakrefable):
         type_name = frombytes(sp.get().type_name())
 
         classes = {
-            'schema': DirectoryPartitioning,
+            'directory': DirectoryPartitioning,
             'hive': HivePartitioning,
         }